1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22 """Functions to bootstrap a new cluster.
23
24 """
25
26 import os
27 import os.path
28 import re
29 import logging
30 import time
31
32 from ganeti import rpc
33 from ganeti import ssh
34 from ganeti import utils
35 from ganeti import errors
36 from ganeti import config
37 from ganeti import constants
38 from ganeti import objects
39 from ganeti import ssconf
40 from ganeti import serializer
41 from ganeti import hypervisor
42 from ganeti import bdev
43 from ganeti import netutils
44 from ganeti import backend
45
46
47 _INITCONF_ECID = "initconfig-ecid"
48
49
51 """Setup the SSH configuration for the cluster.
52
53 This generates a dsa keypair for root, adds the pub key to the
54 permitted hosts and adds the hostkey to its own known hosts.
55
56 """
57 priv_key, pub_key, auth_keys = ssh.GetUserFiles(constants.GANETI_RUNAS)
58
59 for name in priv_key, pub_key:
60 if os.path.exists(name):
61 utils.CreateBackup(name)
62 utils.RemoveFile(name)
63
64 result = utils.RunCmd(["ssh-keygen", "-t", "dsa",
65 "-f", priv_key,
66 "-q", "-N", ""])
67 if result.failed:
68 raise errors.OpExecError("Could not generate ssh keypair, error %s" %
69 result.output)
70
71 utils.AddAuthorizedKey(auth_keys, utils.ReadFile(pub_key))
72
73
75 """Writes a new HMAC key.
76
77 @type file_name: str
78 @param file_name: Path to output file
79
80 """
81 utils.WriteFile(file_name, data="%s\n" % utils.GenerateSecret(), mode=0400,
82 backup=True)
83
84
91 """Updates the cluster certificates, keys and secrets.
92
93 @type new_cluster_cert: bool
94 @param new_cluster_cert: Whether to generate a new cluster certificate
95 @type new_rapi_cert: bool
96 @param new_rapi_cert: Whether to generate a new RAPI certificate
97 @type new_confd_hmac_key: bool
98 @param new_confd_hmac_key: Whether to generate a new HMAC key
99 @type new_cds: bool
100 @param new_cds: Whether to generate a new cluster domain secret
101 @type rapi_cert_pem: string
102 @param rapi_cert_pem: New RAPI certificate in PEM format
103 @type cds: string
104 @param cds: New cluster domain secret
105 @type nodecert_file: string
106 @param nodecert_file: optional override of the node cert file path
107 @type rapicert_file: string
108 @param rapicert_file: optional override of the rapi cert file path
109 @type hmackey_file: string
110 @param hmackey_file: optional override of the hmac key file path
111
112 """
113
114 cluster_cert_exists = os.path.exists(nodecert_file)
115 if new_cluster_cert or not cluster_cert_exists:
116 if cluster_cert_exists:
117 utils.CreateBackup(nodecert_file)
118
119 logging.debug("Generating new cluster certificate at %s", nodecert_file)
120 utils.GenerateSelfSignedSslCert(nodecert_file)
121
122
123 if new_confd_hmac_key or not os.path.exists(hmackey_file):
124 logging.debug("Writing new confd HMAC key to %s", hmackey_file)
125 GenerateHmacKey(hmackey_file)
126
127
128 rapi_cert_exists = os.path.exists(rapicert_file)
129
130 if rapi_cert_pem:
131
132 logging.debug("Writing RAPI certificate at %s", rapicert_file)
133 utils.WriteFile(rapicert_file, data=rapi_cert_pem, backup=True)
134
135 elif new_rapi_cert or not rapi_cert_exists:
136 if rapi_cert_exists:
137 utils.CreateBackup(rapicert_file)
138
139 logging.debug("Generating new RAPI certificate at %s", rapicert_file)
140 utils.GenerateSelfSignedSslCert(rapicert_file)
141
142
143 if cds:
144 logging.debug("Writing cluster domain secret to %s", cds_file)
145 utils.WriteFile(cds_file, data=cds, backup=True)
146
147 elif new_cds or not os.path.exists(cds_file):
148 logging.debug("Generating new cluster domain secret at %s", cds_file)
149 GenerateHmacKey(cds_file)
150
151
153 """Setup the necessary configuration for the initial node daemon.
154
155 This creates the nodepass file containing the shared password for
156 the cluster, generates the SSL certificate and starts the node daemon.
157
158 @type master_name: str
159 @param master_name: Name of the master node
160
161 """
162
163 GenerateClusterCrypto(True, False, False, False)
164
165 result = utils.RunCmd([constants.DAEMON_UTIL, "start", constants.NODED])
166 if result.failed:
167 raise errors.OpExecError("Could not start the node daemon, command %s"
168 " had exitcode %s and error %s" %
169 (result.cmd, result.exit_code, result.output))
170
171 _WaitForNodeDaemon(master_name)
172
173
175 """Wait for node daemon to become responsive.
176
177 """
178 def _CheckNodeDaemon():
179 result = rpc.RpcRunner.call_version([node_name])[node_name]
180 if result.fail_msg:
181 raise utils.RetryAgain()
182
183 try:
184 utils.Retry(_CheckNodeDaemon, 1.0, 10.0)
185 except utils.RetryTimeout:
186 raise errors.OpExecError("Node daemon on %s didn't answer queries within"
187 " 10 seconds" % node_name)
188
189
191 """Initialize if needed the file storage.
192
193 @param file_storage_dir: the user-supplied value
194 @return: either empty string (if file storage was disabled at build
195 time) or the normalized path to the storage directory
196
197 """
198 if not constants.ENABLE_FILE_STORAGE:
199 return ""
200
201 file_storage_dir = os.path.normpath(file_storage_dir)
202
203 if not os.path.isabs(file_storage_dir):
204 raise errors.OpPrereqError("The file storage directory you passed is"
205 " not an absolute path.", errors.ECODE_INVAL)
206
207 if not os.path.exists(file_storage_dir):
208 try:
209 os.makedirs(file_storage_dir, 0750)
210 except OSError, err:
211 raise errors.OpPrereqError("Cannot create file storage directory"
212 " '%s': %s" % (file_storage_dir, err),
213 errors.ECODE_ENVIRON)
214
215 if not os.path.isdir(file_storage_dir):
216 raise errors.OpPrereqError("The file storage directory '%s' is not"
217 " a directory." % file_storage_dir,
218 errors.ECODE_ENVIRON)
219 return file_storage_dir
220
221
222
223 -def InitCluster(cluster_name, mac_prefix,
224 master_netdev, file_storage_dir, candidate_pool_size,
225 secondary_ip=None, vg_name=None, beparams=None,
226 nicparams=None, hvparams=None, enabled_hypervisors=None,
227 modify_etc_hosts=True, modify_ssh_setup=True,
228 maintain_node_health=False, drbd_helper=None,
229 uid_pool=None, default_iallocator=None,
230 primary_ip_version=None, prealloc_wipe_disks=False):
231 """Initialise the cluster.
232
233 @type candidate_pool_size: int
234 @param candidate_pool_size: master candidate pool size
235
236 """
237
238 if config.ConfigWriter.IsCluster():
239 raise errors.OpPrereqError("Cluster is already initialised",
240 errors.ECODE_STATE)
241
242 if not enabled_hypervisors:
243 raise errors.OpPrereqError("Enabled hypervisors list must contain at"
244 " least one member", errors.ECODE_INVAL)
245 invalid_hvs = set(enabled_hypervisors) - constants.HYPER_TYPES
246 if invalid_hvs:
247 raise errors.OpPrereqError("Enabled hypervisors contains invalid"
248 " entries: %s" % invalid_hvs,
249 errors.ECODE_INVAL)
250
251
252 ipcls = None
253 if primary_ip_version == constants.IP4_VERSION:
254 ipcls = netutils.IP4Address
255 elif primary_ip_version == constants.IP6_VERSION:
256 ipcls = netutils.IP6Address
257 else:
258 raise errors.OpPrereqError("Invalid primary ip version: %d." %
259 primary_ip_version)
260
261 hostname = netutils.GetHostname(family=ipcls.family)
262 if not ipcls.IsValid(hostname.ip):
263 raise errors.OpPrereqError("This host's IP (%s) is not a valid IPv%d"
264 " address." % (hostname.ip, primary_ip_version))
265
266 if ipcls.IsLoopback(hostname.ip):
267 raise errors.OpPrereqError("This host's IP (%s) resolves to a loopback"
268 " address. Please fix DNS or %s." %
269 (hostname.ip, constants.ETC_HOSTS),
270 errors.ECODE_ENVIRON)
271
272 if not ipcls.Own(hostname.ip):
273 raise errors.OpPrereqError("Inconsistency: this host's name resolves"
274 " to %s,\nbut this ip address does not"
275 " belong to this host" %
276 hostname.ip, errors.ECODE_ENVIRON)
277
278 clustername = netutils.GetHostname(name=cluster_name, family=ipcls.family)
279
280 if netutils.TcpPing(clustername.ip, constants.DEFAULT_NODED_PORT, timeout=5):
281 raise errors.OpPrereqError("Cluster IP already active",
282 errors.ECODE_NOTUNIQUE)
283
284 if not secondary_ip:
285 if primary_ip_version == constants.IP6_VERSION:
286 raise errors.OpPrereqError("When using a IPv6 primary address, a valid"
287 " IPv4 address must be given as secondary",
288 errors.ECODE_INVAL)
289 secondary_ip = hostname.ip
290
291 if not netutils.IP4Address.IsValid(secondary_ip):
292 raise errors.OpPrereqError("Secondary IP address (%s) has to be a valid"
293 " IPv4 address." % secondary_ip,
294 errors.ECODE_INVAL)
295
296 if not netutils.IP4Address.Own(secondary_ip):
297 raise errors.OpPrereqError("You gave %s as secondary IP,"
298 " but it does not belong to this host." %
299 secondary_ip, errors.ECODE_ENVIRON)
300
301 if vg_name is not None:
302
303 vgstatus = utils.CheckVolumeGroupSize(utils.ListVolumeGroups(), vg_name,
304 constants.MIN_VG_SIZE)
305 if vgstatus:
306 raise errors.OpPrereqError("Error: %s\nspecify --no-lvm-storage if"
307 " you are not using lvm" % vgstatus,
308 errors.ECODE_INVAL)
309
310 if drbd_helper is not None:
311 try:
312 curr_helper = bdev.BaseDRBD.GetUsermodeHelper()
313 except errors.BlockDeviceError, err:
314 raise errors.OpPrereqError("Error while checking drbd helper"
315 " (specify --no-drbd-storage if you are not"
316 " using drbd): %s" % str(err),
317 errors.ECODE_ENVIRON)
318 if drbd_helper != curr_helper:
319 raise errors.OpPrereqError("Error: requiring %s as drbd helper but %s"
320 " is the current helper" % (drbd_helper,
321 curr_helper),
322 errors.ECODE_INVAL)
323
324 file_storage_dir = _InitFileStorage(file_storage_dir)
325
326 if not re.match("^[0-9a-z]{2}:[0-9a-z]{2}:[0-9a-z]{2}$", mac_prefix):
327 raise errors.OpPrereqError("Invalid mac prefix given '%s'" % mac_prefix,
328 errors.ECODE_INVAL)
329
330 result = utils.RunCmd(["ip", "link", "show", "dev", master_netdev])
331 if result.failed:
332 raise errors.OpPrereqError("Invalid master netdev given (%s): '%s'" %
333 (master_netdev,
334 result.output.strip()), errors.ECODE_INVAL)
335
336 dirs = [(constants.RUN_GANETI_DIR, constants.RUN_DIRS_MODE)]
337 utils.EnsureDirs(dirs)
338
339 utils.ForceDictType(beparams, constants.BES_PARAMETER_TYPES)
340 utils.ForceDictType(nicparams, constants.NICS_PARAMETER_TYPES)
341 objects.NIC.CheckParameterSyntax(nicparams)
342
343
344 for hv_name, hv_params in hvparams.iteritems():
345 utils.ForceDictType(hv_params, constants.HVS_PARAMETER_TYPES)
346 hv_class = hypervisor.GetHypervisor(hv_name)
347 hv_class.CheckParameterSyntax(hv_params)
348
349
350 sshline = utils.ReadFile(constants.SSH_HOST_RSA_PUB)
351 sshkey = sshline.split(" ")[1]
352
353 if modify_etc_hosts:
354 utils.AddHostToEtcHosts(hostname.name, hostname.ip)
355
356 if modify_ssh_setup:
357 _InitSSHSetup()
358
359 if default_iallocator is not None:
360 alloc_script = utils.FindFile(default_iallocator,
361 constants.IALLOCATOR_SEARCH_PATH,
362 os.path.isfile)
363 if alloc_script is None:
364 raise errors.OpPrereqError("Invalid default iallocator script '%s'"
365 " specified" % default_iallocator,
366 errors.ECODE_INVAL)
367
368 now = time.time()
369
370
371 cluster_config = objects.Cluster(
372 serial_no=1,
373 rsahostkeypub=sshkey,
374 highest_used_port=(constants.FIRST_DRBD_PORT - 1),
375 mac_prefix=mac_prefix,
376 volume_group_name=vg_name,
377 tcpudp_port_pool=set(),
378 master_node=hostname.name,
379 master_ip=clustername.ip,
380 master_netdev=master_netdev,
381 cluster_name=clustername.name,
382 file_storage_dir=file_storage_dir,
383 enabled_hypervisors=enabled_hypervisors,
384 beparams={constants.PP_DEFAULT: beparams},
385 nicparams={constants.PP_DEFAULT: nicparams},
386 hvparams=hvparams,
387 candidate_pool_size=candidate_pool_size,
388 modify_etc_hosts=modify_etc_hosts,
389 modify_ssh_setup=modify_ssh_setup,
390 uid_pool=uid_pool,
391 ctime=now,
392 mtime=now,
393 maintain_node_health=maintain_node_health,
394 drbd_usermode_helper=drbd_helper,
395 default_iallocator=default_iallocator,
396 primary_ip_family=ipcls.family,
397 prealloc_wipe_disks=prealloc_wipe_disks,
398 )
399 master_node_config = objects.Node(name=hostname.name,
400 primary_ip=hostname.ip,
401 secondary_ip=secondary_ip,
402 serial_no=1,
403 master_candidate=True,
404 offline=False, drained=False,
405 )
406 InitConfig(constants.CONFIG_VERSION, cluster_config, master_node_config)
407 cfg = config.ConfigWriter(offline=True)
408 ssh.WriteKnownHostsFile(cfg, constants.SSH_KNOWN_HOSTS_FILE)
409 cfg.Update(cfg.GetClusterInfo(), logging.error)
410 backend.WriteSsconfFiles(cfg.GetSsconfValues())
411
412
413 _InitGanetiServerSetup(hostname.name)
414
415
416
417
418 rpc.RpcRunner.call_node_start_master(hostname.name, True, False)
419
420
423 """Create the initial cluster configuration.
424
425 It will contain the current node, which will also be the master
426 node, and no instances.
427
428 @type version: int
429 @param version: configuration version
430 @type cluster_config: L{objects.Cluster}
431 @param cluster_config: cluster configuration
432 @type master_node_config: L{objects.Node}
433 @param master_node_config: master node configuration
434 @type cfg_file: string
435 @param cfg_file: configuration file path
436
437 """
438 uuid_generator = config.TemporaryReservationManager()
439 cluster_config.uuid = uuid_generator.Generate([], utils.NewUUID,
440 _INITCONF_ECID)
441 master_node_config.uuid = uuid_generator.Generate([], utils.NewUUID,
442 _INITCONF_ECID)
443 nodes = {
444 master_node_config.name: master_node_config,
445 }
446 default_nodegroup = objects.NodeGroup(
447 uuid=uuid_generator.Generate([], utils.NewUUID, _INITCONF_ECID),
448 name="default",
449 members=[master_node_config.name],
450 )
451 nodegroups = {
452 default_nodegroup.uuid: default_nodegroup,
453 }
454 now = time.time()
455 config_data = objects.ConfigData(version=version,
456 cluster=cluster_config,
457 nodegroups=nodegroups,
458 nodes=nodes,
459 instances={},
460 serial_no=1,
461 ctime=now, mtime=now)
462 utils.WriteFile(cfg_file,
463 data=serializer.Dump(config_data.ToDict()),
464 mode=0600)
465
466
468 """Execute the last steps of cluster destroy
469
470 This function shuts down all the daemons, completing the destroy
471 begun in cmdlib.LUDestroyOpcode.
472
473 """
474 cfg = config.ConfigWriter()
475 modify_ssh_setup = cfg.GetClusterInfo().modify_ssh_setup
476 result = rpc.RpcRunner.call_node_stop_master(master, True)
477 msg = result.fail_msg
478 if msg:
479 logging.warning("Could not disable the master role: %s", msg)
480 result = rpc.RpcRunner.call_node_leave_cluster(master, modify_ssh_setup)
481 msg = result.fail_msg
482 if msg:
483 logging.warning("Could not shutdown the node daemon and cleanup"
484 " the node: %s", msg)
485
486
488 """Add a node to the cluster.
489
490 This function must be called before the actual opcode, and will ssh
491 to the remote node, copy the needed files, and start ganeti-noded,
492 allowing the master to do the rest via normal rpc calls.
493
494 @param cluster_name: the cluster name
495 @param node: the name of the new node
496 @param ssh_key_check: whether to do a strict key check
497
498 """
499 family = ssconf.SimpleStore().GetPrimaryIPFamily()
500 sshrunner = ssh.SshRunner(cluster_name,
501 ipv6=family==netutils.IP6Address.family)
502
503 noded_cert = utils.ReadFile(constants.NODED_CERT_FILE)
504 rapi_cert = utils.ReadFile(constants.RAPI_CERT_FILE)
505 confd_hmac_key = utils.ReadFile(constants.CONFD_HMAC_KEY)
506
507
508
509
510
511
512 for content in (noded_cert, rapi_cert, confd_hmac_key):
513 if re.search('^!EOF\.', content, re.MULTILINE):
514 raise errors.OpExecError("invalid SSL certificate or HMAC key")
515
516 if not noded_cert.endswith("\n"):
517 noded_cert += "\n"
518 if not rapi_cert.endswith("\n"):
519 rapi_cert += "\n"
520 if not confd_hmac_key.endswith("\n"):
521 confd_hmac_key += "\n"
522
523 bind_address = constants.IP4_ADDRESS_ANY
524 if family == netutils.IP6Address.family:
525 bind_address = constants.IP6_ADDRESS_ANY
526
527
528
529
530
531 sshrunner.CopyFileToNode(node, constants.NODED_CERT_FILE)
532 sshrunner.CopyFileToNode(node, constants.RAPI_CERT_FILE)
533 sshrunner.CopyFileToNode(node, constants.CONFD_HMAC_KEY)
534 mycommand = ("%s stop-all; %s start %s -b '%s'" % (constants.DAEMON_UTIL,
535 constants.DAEMON_UTIL,
536 constants.NODED,
537 bind_address))
538
539 result = sshrunner.Run(node, 'root', mycommand, batch=False,
540 ask_key=ssh_key_check,
541 use_cluster_key=True,
542 strict_host_check=ssh_key_check)
543 if result.failed:
544 raise errors.OpExecError("Remote command on node %s, error: %s,"
545 " output: %s" %
546 (node, result.fail_reason, result.output))
547
548 _WaitForNodeDaemon(node)
549
550
552 """Failover the master node.
553
554 This checks that we are not already the master, and will cause the
555 current master to cease being master, and the non-master to become
556 new master.
557
558 @type no_voting: boolean
559 @param no_voting: force the operation without remote nodes agreement
560 (dangerous)
561
562 """
563 sstore = ssconf.SimpleStore()
564
565 old_master, new_master = ssconf.GetMasterAndMyself(sstore)
566 node_list = sstore.GetNodeList()
567 mc_list = sstore.GetMasterCandidates()
568
569 if old_master == new_master:
570 raise errors.OpPrereqError("This commands must be run on the node"
571 " where you want the new master to be."
572 " %s is already the master" %
573 old_master, errors.ECODE_INVAL)
574
575 if new_master not in mc_list:
576 mc_no_master = [name for name in mc_list if name != old_master]
577 raise errors.OpPrereqError("This node is not among the nodes marked"
578 " as master candidates. Only these nodes"
579 " can become masters. Current list of"
580 " master candidates is:\n"
581 "%s" % ('\n'.join(mc_no_master)),
582 errors.ECODE_STATE)
583
584 if not no_voting:
585 vote_list = GatherMasterVotes(node_list)
586
587 if vote_list:
588 voted_master = vote_list[0][0]
589 if voted_master is None:
590 raise errors.OpPrereqError("Cluster is inconsistent, most nodes did"
591 " not respond.", errors.ECODE_ENVIRON)
592 elif voted_master != old_master:
593 raise errors.OpPrereqError("I have a wrong configuration, I believe"
594 " the master is %s but the other nodes"
595 " voted %s. Please resync the configuration"
596 " of this node." %
597 (old_master, voted_master),
598 errors.ECODE_STATE)
599
600
601 rcode = 0
602
603 logging.info("Setting master to %s, old master: %s", new_master, old_master)
604
605 try:
606
607
608 cfg = config.ConfigWriter(accept_foreign=True)
609
610 cluster_info = cfg.GetClusterInfo()
611 cluster_info.master_node = new_master
612
613
614 cfg.Update(cluster_info, logging.error)
615 except errors.ConfigurationError, err:
616 logging.error("Error while trying to set the new master: %s",
617 str(err))
618 return 1
619
620
621
622
623
624
625 logging.info("Stopping the master daemon on node %s", old_master)
626
627 result = rpc.RpcRunner.call_node_stop_master(old_master, True)
628 msg = result.fail_msg
629 if msg:
630 logging.error("Could not disable the master role on the old master"
631 " %s, please disable manually: %s", old_master, msg)
632
633 logging.info("Checking master IP non-reachability...")
634
635 master_ip = sstore.GetMasterIP()
636 total_timeout = 30
637
638 def _check_ip():
639 if netutils.TcpPing(master_ip, constants.DEFAULT_NODED_PORT):
640 raise utils.RetryAgain()
641
642 try:
643 utils.Retry(_check_ip, (1, 1.5, 5), total_timeout)
644 except utils.RetryTimeout:
645 logging.warning("The master IP is still reachable after %s seconds,"
646 " continuing but activating the master on the current"
647 " node will probably fail", total_timeout)
648
649 logging.info("Starting the master daemons on the new master")
650
651 result = rpc.RpcRunner.call_node_start_master(new_master, True, no_voting)
652 msg = result.fail_msg
653 if msg:
654 logging.error("Could not start the master role on the new master"
655 " %s, please check: %s", new_master, msg)
656 rcode = 1
657
658 logging.info("Master failed over from %s to %s", old_master, new_master)
659 return rcode
660
661
663 """Returns the current master node.
664
665 This is a separate function in bootstrap since it's needed by
666 gnt-cluster, and instead of importing directly ssconf, it's better
667 to abstract it in bootstrap, where we do use ssconf in other
668 functions too.
669
670 """
671 sstore = ssconf.SimpleStore()
672
673 old_master, _ = ssconf.GetMasterAndMyself(sstore)
674
675 return old_master
676
677
679 """Check the agreement on who is the master.
680
681 This function will return a list of (node, number of votes), ordered
682 by the number of votes. Errors will be denoted by the key 'None'.
683
684 Note that the sum of votes is the number of nodes this machine
685 knows, whereas the number of entries in the list could be different
686 (if some nodes vote for another master).
687
688 We remove ourselves from the list since we know that (bugs aside)
689 since we use the same source for configuration information for both
690 backend and boostrap, we'll always vote for ourselves.
691
692 @type node_list: list
693 @param node_list: the list of nodes to query for master info; the current
694 node will be removed if it is in the list
695 @rtype: list
696 @return: list of (node, votes)
697
698 """
699 myself = netutils.Hostname.GetSysName()
700 try:
701 node_list.remove(myself)
702 except ValueError:
703 pass
704 if not node_list:
705
706 return []
707 results = rpc.RpcRunner.call_master_info(node_list)
708 if not isinstance(results, dict):
709
710 logging.critical("Can't complete rpc call, aborting master startup")
711 return [(None, len(node_list))]
712 votes = {}
713 for node in results:
714 nres = results[node]
715 data = nres.payload
716 msg = nres.fail_msg
717 fail = False
718 if msg:
719 logging.warning("Error contacting node %s: %s", node, msg)
720 fail = True
721
722 elif not isinstance(data, (tuple, list)) or len(data) < 3:
723 logging.warning("Invalid data received from node %s: %s", node, data)
724 fail = True
725 if fail:
726 if None not in votes:
727 votes[None] = 0
728 votes[None] += 1
729 continue
730 master_node = data[2]
731 if master_node not in votes:
732 votes[master_node] = 0
733 votes[master_node] += 1
734
735 vote_list = [v for v in votes.items()]
736
737
738
739 vote_list.sort(key=lambda x: (x[1], x[0]), reverse=True)
740
741 return vote_list
742