Package ganeti :: Package cmdlib :: Module base
[hide private]
[frames] | no frames]

Source Code for Module ganeti.cmdlib.base

  1  # 
  2  # 
  3   
  4  # Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Google Inc. 
  5  # All rights reserved. 
  6  # 
  7  # Redistribution and use in source and binary forms, with or without 
  8  # modification, are permitted provided that the following conditions are 
  9  # met: 
 10  # 
 11  # 1. Redistributions of source code must retain the above copyright notice, 
 12  # this list of conditions and the following disclaimer. 
 13  # 
 14  # 2. Redistributions in binary form must reproduce the above copyright 
 15  # notice, this list of conditions and the following disclaimer in the 
 16  # documentation and/or other materials provided with the distribution. 
 17  # 
 18  # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
 19  # IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED 
 20  # TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
 21  # PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR 
 22  # CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 
 23  # EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 
 24  # PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 
 25  # PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF 
 26  # LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING 
 27  # NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS 
 28  # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 29   
 30   
 31  """Base classes and functions for cmdlib.""" 
 32   
 33  import logging 
 34   
 35  from ganeti import errors 
 36  from ganeti import constants 
 37  from ganeti import locking 
 38  from ganeti import query 
 39  from ganeti import utils 
 40  from ganeti.cmdlib.common import ExpandInstanceUuidAndName 
 41   
 42   
43 -class ResultWithJobs(object):
44 """Data container for LU results with jobs. 45 46 Instances of this class returned from L{LogicalUnit.Exec} will be recognized 47 by L{mcpu._ProcessResult}. The latter will then submit the jobs 48 contained in the C{jobs} attribute and include the job IDs in the opcode 49 result. 50 51 """
52 - def __init__(self, jobs, **kwargs):
53 """Initializes this class. 54 55 Additional return values can be specified as keyword arguments. 56 57 @type jobs: list of lists of L{opcode.OpCode} 58 @param jobs: A list of lists of opcode objects 59 60 """ 61 self.jobs = jobs 62 self.other = kwargs
63 64
65 -class LUWConfdClient(object):
66 """Wrapper class for wconfd client calls from LUs. 67 68 Correctly updates the cache of the LU's owned locks 69 when leaving. Also transparently adds the context 70 for resource requests. 71 72 """
73 - def __init__(self, lu):
74 self.lu = lu
75
76 - def TryUpdateLocks(self, req):
77 self.lu.wconfd.Client().TryUpdateLocks(self.lu.wconfdcontext, req) 78 self.lu.wconfdlocks = \ 79 self.lu.wconfd.Client().ListLocks(self.lu.wconfdcontext)
80
81 - def DownGradeLocksLevel(self, level):
82 self.lu.wconfd.Client().DownGradeLocksLevel(self.lu.wconfdcontext, level) 83 self.lu.wconfdlocks = \ 84 self.lu.wconfd.Client().ListLocks(self.lu.wconfdcontext)
85
86 - def FreeLocksLevel(self, level):
87 self.lu.wconfd.Client().FreeLocksLevel(self.lu.wconfdcontext, level) 88 self.lu.wconfdlocks = \ 89 self.lu.wconfd.Client().ListLocks(self.lu.wconfdcontext)
90 91
92 -class LogicalUnit(object): # pylint: disable=R0902
93 """Logical Unit base class. 94 95 Subclasses must follow these rules: 96 - implement ExpandNames 97 - implement CheckPrereq (except when tasklets are used) 98 - implement Exec (except when tasklets are used) 99 - implement BuildHooksEnv 100 - implement BuildHooksNodes 101 - redefine HPATH and HTYPE 102 - optionally redefine their run requirements: 103 REQ_BGL: the LU needs to hold the Big Ganeti Lock exclusively 104 105 Note that all commands require root permissions. 106 107 @ivar dry_run_result: the value (if any) that will be returned to the caller 108 in dry-run mode (signalled by opcode dry_run parameter) 109 110 """ 111 # This class has more than 20 instance variables, but at most have sensible 112 # defaults and are used in a declartive way, this is not a problem. 113 114 HPATH = None 115 HTYPE = None 116 REQ_BGL = True 117
118 - def __init__(self, processor, op, cfg, 119 rpc_runner, wconfdcontext, wconfd):
120 """Constructor for LogicalUnit. 121 122 This needs to be overridden in derived classes in order to check op 123 validity. 124 125 @type wconfdcontext: (int, string) 126 @param wconfdcontext: the identity of the logical unit to represent itself 127 to wconfd when asking for resources; it is given as job id and livelock 128 file. 129 @param wconfd: the wconfd class to use; dependency injection to allow 130 testability. 131 132 """ 133 self.proc = processor 134 self.op = op 135 self.cfg = cfg 136 self.wconfdlocks = [] 137 self.wconfdcontext = wconfdcontext 138 self.rpc = rpc_runner 139 self.wconfd = wconfd # wconfd module to use, for testing 140 141 # Dictionaries used to declare locking needs to mcpu 142 self.needed_locks = None 143 self.share_locks = dict.fromkeys(locking.LEVELS, 0) 144 self.opportunistic_locks = dict.fromkeys(locking.LEVELS, False) 145 self.opportunistic_locks_count = dict.fromkeys(locking.LEVELS, 1) 146 self.dont_collate_locks = dict.fromkeys(locking.LEVELS, False) 147 148 self.add_locks = {} 149 150 # Used to force good behavior when calling helper functions 151 self.recalculate_locks = {} 152 153 # logging 154 self.Log = processor.Log # pylint: disable=C0103 155 self.LogWarning = processor.LogWarning # pylint: disable=C0103 156 self.LogInfo = processor.LogInfo # pylint: disable=C0103 157 self.LogStep = processor.LogStep # pylint: disable=C0103 158 # support for dry-run 159 self.dry_run_result = None 160 # support for generic debug attribute 161 if (not hasattr(self.op, "debug_level") or 162 not isinstance(self.op.debug_level, int)): 163 self.op.debug_level = 0 164 165 # Tasklets 166 self.tasklets = None 167 168 # Validate opcode parameters and set defaults 169 self.op.Validate(True) 170 171 self.CheckArguments()
172
173 - def WConfdClient(self):
174 return LUWConfdClient(self)
175
176 - def owned_locks(self, level):
177 """Return the list of locks owned by the LU at a given level. 178 179 This method assumes that is field wconfdlocks is set correctly 180 by mcpu. 181 182 """ 183 levelprefix = "%s/" % (locking.LEVEL_NAMES[level],) 184 locks = set([lock[0][len(levelprefix):] 185 for lock in self.wconfdlocks 186 if lock[0].startswith(levelprefix)]) 187 expand_fns = { 188 locking.LEVEL_CLUSTER: (lambda: [locking.BGL]), 189 locking.LEVEL_INSTANCE: 190 lambda: self.cfg.GetInstanceNames(self.cfg.GetInstanceList()), 191 locking.LEVEL_NODEGROUP: self.cfg.GetNodeGroupList, 192 locking.LEVEL_NODE: self.cfg.GetNodeList, 193 locking.LEVEL_NODE_RES: self.cfg.GetNodeList, 194 locking.LEVEL_NETWORK: self.cfg.GetNetworkList, 195 } 196 if locking.LOCKSET_NAME in locks: 197 return expand_fns[level]() 198 else: 199 return locks
200
201 - def release_request(self, level, names):
202 """Return a request to release the specified locks of the given level. 203 204 Correctly break up the group lock to do so. 205 206 """ 207 levelprefix = "%s/" % (locking.LEVEL_NAMES[level],) 208 release = [[levelprefix + lock, "release"] for lock in names] 209 210 # if we break up the set-lock, make sure we ask for the rest of it. 211 setlock = levelprefix + locking.LOCKSET_NAME 212 if [setlock, "exclusive"] in self.wconfdlocks: 213 owned = self.owned_locks(level) 214 request = [[levelprefix + lock, "exclusive"] 215 for lock in owned 216 if lock not in names] 217 elif [setlock, "shared"] in self.wconfdlocks: 218 owned = self.owned_locks(level) 219 request = [[levelprefix + lock, "shared"] 220 for lock in owned 221 if lock not in names] 222 else: 223 request = [] 224 225 return release + [[setlock, "release"]] + request
226
227 - def CheckArguments(self):
228 """Check syntactic validity for the opcode arguments. 229 230 This method is for doing a simple syntactic check and ensure 231 validity of opcode parameters, without any cluster-related 232 checks. While the same can be accomplished in ExpandNames and/or 233 CheckPrereq, doing these separate is better because: 234 235 - ExpandNames is left as as purely a lock-related function 236 - CheckPrereq is run after we have acquired locks (and possible 237 waited for them) 238 239 The function is allowed to change the self.op attribute so that 240 later methods can no longer worry about missing parameters. 241 242 """ 243 pass
244
245 - def ExpandNames(self):
246 """Expand names for this LU. 247 248 This method is called before starting to execute the opcode, and it should 249 update all the parameters of the opcode to their canonical form (e.g. a 250 short node name must be fully expanded after this method has successfully 251 completed). This way locking, hooks, logging, etc. can work correctly. 252 253 LUs which implement this method must also populate the self.needed_locks 254 member, as a dict with lock levels as keys, and a list of needed lock names 255 as values. Rules: 256 257 - use an empty dict if you don't need any lock 258 - if you don't need any lock at a particular level omit that 259 level (note that in this case C{DeclareLocks} won't be called 260 at all for that level) 261 - if you need locks at a level, but you can't calculate it in 262 this function, initialise that level with an empty list and do 263 further processing in L{LogicalUnit.DeclareLocks} (see that 264 function's docstring) 265 - don't put anything for the BGL level 266 - if you want all locks at a level use L{locking.ALL_SET} as a value 267 268 If you need to share locks (rather than acquire them exclusively) at one 269 level you can modify self.share_locks, setting a true value (usually 1) for 270 that level. By default locks are not shared. 271 272 This function can also define a list of tasklets, which then will be 273 executed in order instead of the usual LU-level CheckPrereq and Exec 274 functions, if those are not defined by the LU. 275 276 Examples:: 277 278 # Acquire all nodes and one instance 279 self.needed_locks = { 280 locking.LEVEL_NODE: locking.ALL_SET, 281 locking.LEVEL_INSTANCE: ['instance1.example.com'], 282 } 283 # Acquire just two nodes 284 self.needed_locks = { 285 locking.LEVEL_NODE: ['node1-uuid', 'node2-uuid'], 286 } 287 # Acquire no locks 288 self.needed_locks = {} # No, you can't leave it to the default value None 289 290 """ 291 # The implementation of this method is mandatory only if the new LU is 292 # concurrent, so that old LUs don't need to be changed all at the same 293 # time. 294 if self.REQ_BGL: 295 self.needed_locks = {} # Exclusive LUs don't need locks. 296 else: 297 raise NotImplementedError
298
299 - def DeclareLocks(self, level):
300 """Declare LU locking needs for a level 301 302 While most LUs can just declare their locking needs at ExpandNames time, 303 sometimes there's the need to calculate some locks after having acquired 304 the ones before. This function is called just before acquiring locks at a 305 particular level, but after acquiring the ones at lower levels, and permits 306 such calculations. It can be used to modify self.needed_locks, and by 307 default it does nothing. 308 309 This function is only called if you have something already set in 310 self.needed_locks for the level. 311 312 @param level: Locking level which is going to be locked 313 @type level: member of L{ganeti.locking.LEVELS} 314 315 """
316
317 - def CheckPrereq(self):
318 """Check prerequisites for this LU. 319 320 This method should check that the prerequisites for the execution 321 of this LU are fulfilled. It can do internode communication, but 322 it should be idempotent - no cluster or system changes are 323 allowed. 324 325 The method should raise errors.OpPrereqError in case something is 326 not fulfilled. Its return value is ignored. 327 328 This method should also update all the parameters of the opcode to 329 their canonical form if it hasn't been done by ExpandNames before. 330 331 """ 332 if self.tasklets is not None: 333 for (idx, tl) in enumerate(self.tasklets): 334 logging.debug("Checking prerequisites for tasklet %s/%s", 335 idx + 1, len(self.tasklets)) 336 tl.CheckPrereq() 337 else: 338 pass
339
340 - def Exec(self, feedback_fn):
341 """Execute the LU. 342 343 This method should implement the actual work. It should raise 344 errors.OpExecError for failures that are somewhat dealt with in 345 code, or expected. 346 347 """ 348 if self.tasklets is not None: 349 for (idx, tl) in enumerate(self.tasklets): 350 logging.debug("Executing tasklet %s/%s", idx + 1, len(self.tasklets)) 351 tl.Exec(feedback_fn) 352 else: 353 raise NotImplementedError
354
355 - def PrepareRetry(self, _feedback_fn):
356 """Prepare the LU to run again. 357 358 This method is called if the Exec failed for temporarily lacking resources. 359 It is expected to change the state of the LU so that it can be tried again, 360 and also change its locking policy to acquire more resources to have a 361 better chance of suceeding in the retry. 362 363 """ 364 # pylint: disable=R0201 365 raise errors.OpRetryNotSupportedError()
366
367 - def BuildHooksEnv(self):
368 """Build hooks environment for this LU. 369 370 @rtype: dict 371 @return: Dictionary containing the environment that will be used for 372 running the hooks for this LU. The keys of the dict must not be prefixed 373 with "GANETI_"--that'll be added by the hooks runner. The hooks runner 374 will extend the environment with additional variables. If no environment 375 should be defined, an empty dictionary should be returned (not C{None}). 376 @note: If the C{HPATH} attribute of the LU class is C{None}, this function 377 will not be called. 378 379 """ 380 raise NotImplementedError
381
382 - def BuildHooksNodes(self):
383 """Build list of nodes to run LU's hooks. 384 385 @rtype: tuple; (list, list) 386 @return: Tuple containing a list of node UUIDs on which the hook 387 should run before the execution and a list of node UUIDs on which the 388 hook should run after the execution. 389 No nodes should be returned as an empty list (and not None). 390 @note: If the C{HPATH} attribute of the LU class is C{None}, this function 391 will not be called. 392 393 """ 394 raise NotImplementedError
395
396 - def PreparePostHookNodes(self, post_hook_node_uuids):
397 """Extend list of nodes to run the post LU hook. 398 399 This method allows LUs to change the list of node UUIDs on which the 400 post hook should run after the LU has been executed but before the post 401 hook is run. 402 403 @type post_hook_node_uuids: list 404 @param post_hook_node_uuids: The initial list of node UUIDs to run the 405 post hook on, as returned by L{BuildHooksNodes}. 406 @rtype: list 407 @return: list of node UUIDs on which the post hook should run. The default 408 implementation returns the passed in C{post_hook_node_uuids}, but 409 custom implementations can choose to alter the list. 410 411 """ 412 # For consistency with HooksCallBack we ignore the "could be a function" 413 # warning 414 # pylint: disable=R0201 415 return post_hook_node_uuids
416
417 - def HooksCallBack(self, phase, hook_results, feedback_fn, lu_result):
418 """Notify the LU about the results of its hooks. 419 420 This method is called every time a hooks phase is executed, and notifies 421 the Logical Unit about the hooks' result. The LU can then use it to alter 422 its result based on the hooks. By default the method does nothing and the 423 previous result is passed back unchanged but any LU can define it if it 424 wants to use the local cluster hook-scripts somehow. 425 426 @param phase: one of L{constants.HOOKS_PHASE_POST} or 427 L{constants.HOOKS_PHASE_PRE}; it denotes the hooks phase 428 @param hook_results: the results of the multi-node hooks rpc call 429 @param feedback_fn: function used send feedback back to the caller 430 @param lu_result: the previous Exec result this LU had, or None 431 in the PRE phase 432 @return: the new Exec result, based on the previous result 433 and hook results 434 435 """ 436 # API must be kept, thus we ignore the unused argument and could 437 # be a function warnings 438 # pylint: disable=W0613,R0201 439 return lu_result
440
441 - def _ExpandAndLockInstance(self, allow_forthcoming=False):
442 """Helper function to expand and lock an instance. 443 444 Many LUs that work on an instance take its name in self.op.instance_name 445 and need to expand it and then declare the expanded name for locking. This 446 function does it, and then updates self.op.instance_name to the expanded 447 name. It also initializes needed_locks as a dict, if this hasn't been done 448 before. 449 450 @param allow_forthcoming: if True, do not insist that the intsance be real; 451 the default behaviour is to raise a prerequisite error if the specified 452 instance is forthcoming. 453 454 """ 455 if self.needed_locks is None: 456 self.needed_locks = {} 457 else: 458 assert locking.LEVEL_INSTANCE not in self.needed_locks, \ 459 "_ExpandAndLockInstance called with instance-level locks set" 460 (self.op.instance_uuid, self.op.instance_name) = \ 461 ExpandInstanceUuidAndName(self.cfg, self.op.instance_uuid, 462 self.op.instance_name) 463 self.needed_locks[locking.LEVEL_INSTANCE] = self.op.instance_name 464 if not allow_forthcoming: 465 if self.cfg.GetInstanceInfo(self.op.instance_uuid).forthcoming: 466 raise errors.OpPrereqError( 467 "forthcoming instances not supported for this operation")
468
469 - def _LockInstancesNodes(self, primary_only=False, 470 level=locking.LEVEL_NODE):
471 """Helper function to declare instances' nodes for locking. 472 473 This function should be called after locking one or more instances to lock 474 their nodes. Its effect is populating self.needed_locks[locking.LEVEL_NODE] 475 with all primary or secondary nodes for instances already locked and 476 present in self.needed_locks[locking.LEVEL_INSTANCE]. 477 478 It should be called from DeclareLocks, and for safety only works if 479 self.recalculate_locks[locking.LEVEL_NODE] is set. 480 481 In the future it may grow parameters to just lock some instance's nodes, or 482 to just lock primaries or secondary nodes, if needed. 483 484 If should be called in DeclareLocks in a way similar to:: 485 486 if level == locking.LEVEL_NODE: 487 self._LockInstancesNodes() 488 489 @type primary_only: boolean 490 @param primary_only: only lock primary nodes of locked instances 491 @param level: Which lock level to use for locking nodes 492 493 """ 494 assert level in self.recalculate_locks, \ 495 "_LockInstancesNodes helper function called with no nodes to recalculate" 496 497 # TODO: check if we're really been called with the instance locks held 498 499 # For now we'll replace self.needed_locks[locking.LEVEL_NODE], but in the 500 # future we might want to have different behaviors depending on the value 501 # of self.recalculate_locks[locking.LEVEL_NODE] 502 wanted_node_uuids = [] 503 locked_i = self.owned_locks(locking.LEVEL_INSTANCE) 504 for _, instance in self.cfg.GetMultiInstanceInfoByName(locked_i): 505 wanted_node_uuids.append(instance.primary_node) 506 if not primary_only: 507 wanted_node_uuids.extend( 508 self.cfg.GetInstanceSecondaryNodes(instance.uuid)) 509 510 if self.recalculate_locks[level] == constants.LOCKS_REPLACE: 511 self.needed_locks[level] = wanted_node_uuids 512 elif self.recalculate_locks[level] == constants.LOCKS_APPEND: 513 self.needed_locks[level].extend(wanted_node_uuids) 514 else: 515 raise errors.ProgrammerError("Unknown recalculation mode") 516 517 del self.recalculate_locks[level]
518
519 - def AssertReleasedLocks(self, level):
520 """Raise AssertionError if the LU holds some locks of the given level. 521 522 """ 523 assert not self.owned_locks(level)
524 525
526 -class NoHooksLU(LogicalUnit): # pylint: disable=W0223
527 """Simple LU which runs no hooks. 528 529 This LU is intended as a parent for other LogicalUnits which will 530 run no hooks, in order to reduce duplicate code. 531 532 """ 533 HPATH = None 534 HTYPE = None 535
536 - def BuildHooksEnv(self):
537 """Empty BuildHooksEnv for NoHooksLu. 538 539 This just raises an error. 540 541 """ 542 raise AssertionError("BuildHooksEnv called for NoHooksLUs")
543
544 - def BuildHooksNodes(self):
545 """Empty BuildHooksNodes for NoHooksLU. 546 547 """ 548 raise AssertionError("BuildHooksNodes called for NoHooksLU")
549
550 - def PreparePostHookNodes(self, post_hook_node_uuids):
551 """Empty PreparePostHookNodes for NoHooksLU. 552 553 """ 554 raise AssertionError("PreparePostHookNodes called for NoHooksLU")
555 556
557 -class Tasklet(object):
558 """Tasklet base class. 559 560 Tasklets are subcomponents for LUs. LUs can consist entirely of tasklets or 561 they can mix legacy code with tasklets. Locking needs to be done in the LU, 562 tasklets know nothing about locks. 563 564 Subclasses must follow these rules: 565 - Implement CheckPrereq 566 - Implement Exec 567 568 """
569 - def __init__(self, lu):
570 self.lu = lu 571 572 # Shortcuts 573 self.cfg = lu.cfg 574 self.rpc = lu.rpc
575
576 - def CheckPrereq(self):
577 """Check prerequisites for this tasklets. 578 579 This method should check whether the prerequisites for the execution of 580 this tasklet are fulfilled. It can do internode communication, but it 581 should be idempotent - no cluster or system changes are allowed. 582 583 The method should raise errors.OpPrereqError in case something is not 584 fulfilled. Its return value is ignored. 585 586 This method should also update all parameters to their canonical form if it 587 hasn't been done before. 588 589 """ 590 pass
591
592 - def Exec(self, feedback_fn):
593 """Execute the tasklet. 594 595 This method should implement the actual work. It should raise 596 errors.OpExecError for failures that are somewhat dealt with in code, or 597 expected. 598 599 """ 600 raise NotImplementedError
601 602
603 -class QueryBase(object):
604 """Base for query utility classes. 605 606 """ 607 #: Attribute holding field definitions 608 FIELDS = None 609 610 #: Field to sort by 611 SORT_FIELD = "name" 612
613 - def __init__(self, qfilter, fields, use_locking):
614 """Initializes this class. 615 616 """ 617 self.use_locking = use_locking 618 619 self.query = query.Query(self.FIELDS, fields, qfilter=qfilter, 620 namefield=self.SORT_FIELD) 621 self.requested_data = self.query.RequestedData() 622 self.names = self.query.RequestedNames() 623 624 # Sort only if no names were requested 625 self.sort_by_name = not self.names 626 627 self.do_locking = None 628 self.wanted = None
629
630 - def _GetNames(self, lu, all_names, lock_level):
631 """Helper function to determine names asked for in the query. 632 633 """ 634 if self.do_locking: 635 names = lu.owned_locks(lock_level) 636 else: 637 names = all_names 638 639 if self.wanted == locking.ALL_SET: 640 assert not self.names 641 # caller didn't specify names, so ordering is not important 642 return utils.NiceSort(names) 643 644 # caller specified names and we must keep the same order 645 assert self.names 646 647 missing = set(self.wanted).difference(names) 648 if missing: 649 raise errors.OpExecError("Some items were removed before retrieving" 650 " their data: %s" % missing) 651 652 # Return expanded names 653 return self.wanted
654
655 - def ExpandNames(self, lu):
656 """Expand names for this query. 657 658 See L{LogicalUnit.ExpandNames}. 659 660 """ 661 raise NotImplementedError()
662
663 - def DeclareLocks(self, lu, level):
664 """Declare locks for this query. 665 666 See L{LogicalUnit.DeclareLocks}. 667 668 """ 669 raise NotImplementedError()
670
671 - def _GetQueryData(self, lu):
672 """Collects all data for this query. 673 674 @return: Query data object 675 676 """ 677 raise NotImplementedError()
678
679 - def NewStyleQuery(self, lu):
680 """Collect data and execute query. 681 682 """ 683 return query.GetQueryResponse(self.query, self._GetQueryData(lu), 684 sort_by_name=self.sort_by_name)
685
686 - def OldStyleQuery(self, lu):
687 """Collect data and execute query. 688 689 """ 690 return self.query.OldStyleQuery(self._GetQueryData(lu), 691 sort_by_name=self.sort_by_name)
692